Skip to content

Hacktoberfest 2020 - coding style for project_euler problem 39 #3023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 9, 2020
Merged

Hacktoberfest 2020 - coding style for project_euler problem 39 #3023

merged 4 commits into from
Oct 9, 2020

Conversation

fa1l
Copy link
Contributor

@fa1l fa1l commented Oct 8, 2020 •
edited
Loading

Describe your change:

Related to #2786

  • Added solution function.

  • Improve type hinting.

  • Add an algorithm?

  • Fix a bug or typo in an existing algorithm?

  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@fa1l fa1l changed the title Hacktoberfest 2020 - coding style with default argument for project_euler problem 39 Hacktoberfest 2020 - coding style for project_euler problem 39 Oct 8, 2020
@dhruvmanila dhruvmanila added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 9, 2020
@dhruvmanila dhruvmanila merged commit 261be28 into TheAlgorithms:master Oct 9, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@fa1l @dhruvmanila @stokhos
Fix coding style for Project Euler problem 39 (TheAlgorithms#3023)
efc3581 
* improvements for project euler task 39

* add tests for solution()

* fixed a typo

* Update sol1.py

Co-authored-by: Dhruv <[email protected]>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@fa1l @dhruvmanila
Fix coding style for Project Euler problem 39 (TheAlgorithms#3023)
e7c8203 
* improvements for project euler task 39

* add tests for solution()

* fixed a typo

* Update sol1.py

Co-authored-by: Dhruv <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fa1l @dhruvmanila